RFR(S): 8196487: AIX: os::get_summary_cpu_info does not need to call into libperfstat

Thomas Stüfe thomas.stuefe at gmail.com
Wed Jan 31 09:30:32 UTC 2018

On Wed, Jan 31, 2018 at 10:10 AM, Langer, Christoph <
christoph.langer at sap.com> wrote:

> Hi,
> please review an AIX only change:
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196487.0/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8196487
> The implementation of os::get_summary_cpu_info() on AIX currently calls
> libperfstat::get_cpuinfo() which in turn only fills the version field of
> struct cpuinfo_t for the purpose of os::get_summary_cpu_info. This should
> be decoupled.
Removal of cpuinfo_t.version: ok.

Move read of _system_configuration to os_aix.cpp: ok, albeit grudgingly,
would have preferred to leave reading and interpreting those AIX internals
to the lowest layer, but that is a matter of taste.

So, change is fine.

Thanks & Regards, Thomas

> Thanks & Best regards
> Christoph

More information about the hotspot-runtime-dev mailing list