RFR(XS): 8204345: [s390]: no precompiled headers build broken

Doerr, Martin martin.doerr at sap.com
Wed Jun 6 08:19:13 UTC 2018

Thanks for reviewing. Pushed.
@Coleen: The implementation was not ideal, so not your fault.

Best regards,

-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of coleen.phillimore at oracle.com
Sent: Dienstag, 5. Juni 2018 21:10
To: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XS): 8204345: [s390]: no precompiled headers build broken

This looks good.  Sorry I should have pinged you before pushing. Next time!

On 6/5/18 12:57 PM, Doerr, Martin wrote:
> Hi,
> the nop() function which calls z_nop() is misplaced in the current implementation which leads to build errors (after JDK-8204195<https://bugs.openjdk.java.net/browse/JDK-8204195>) when not using precompiled headers.
> Please review this fix proposal:
> http://cr.openjdk.java.net/~mdoerr/8204345_s390_nopch/webrev.00/
> Best regards,
> Martin

More information about the hotspot-runtime-dev mailing list