8205054: Could not find "lsof" on test machine
leo.korinth at oracle.com
Thu Jun 14 17:31:35 UTC 2018
On 14/06/18 19:10, Lindenmaier, Goetz wrote:
> Hi Leo,
> the fix looks good. It makes sense to skip a test if the infrastructure is
> insufficient to run it.
> Could you please put the long comment at the end of line 179
> into a line of it's own?
> Also, please take the chance and move the Copyright message
> to the beginning of the file.
> Best regards,
Thanks for the fast review; I need a second reviewer and someone to help
me push (I am not a commiter).
>> -----Original Message-----
>> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
>> bounces at openjdk.java.net] On Behalf Of Leo Korinth
>> Sent: Donnerstag, 14. Juni 2018 18:55
>> To: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>
>> Subject: RFR: 8205054: Could not find "lsof" on test machine
>> Unfortunately some test machines does not have "lsof" installed, or it
>> can not be found.
>> I do not know how to find "lsof" on the test machine where the test
>> fails; the command might not be installed. Here is a fix to make the
>> test case succeed if "lsof" can not be found. I believe it is the best
>> option (at least for now). I am sorry for all the noise I am generating.
>> I have tested this on my machine, and I have a mach5 test job running.
More information about the hotspot-runtime-dev