[8u] RFR: 8150688: Fix os_windows siglabel
kim.barrett at oracle.com
Mon Jun 18 23:42:03 UTC 2018
> On Jun 15, 2018, at 11:41 AM, Kevin Walls <kevin.walls at oracle.com> wrote:
> I'd like to get a review of this backport from 9 to 8u:
> 8150688: Fix os_windows siglabel
> 9 changeset:
> 9 review thread:
> Proposed 8u change:http://cr.openjdk.java.net/~kevinw/8150688/webrev.00/
2228 , def_excpt(EXCEPTION_REG_NAT_CONSUMPTION),
stray trailing comma.
Otherwise, looks good. But note that I am not a JDK 8 reviewer (or even committer).
> This is a pretty clean backport. but didn't import automatically: in 8u
> there is no "os::get_signal_number()" and some of the def_excpt... lines
> didn't apply automatically, but they are the same change.
> This removes some errors when varying the windows compiler in use, still
> builds and tests OK on current standard VS compiler.
More information about the hotspot-runtime-dev