[8u] RFR: 8150688: Fix os_windows siglabel
david.holmes at oracle.com
Tue Jun 19 02:07:32 UTC 2018
Other than the stray comma looks fine.
On 19/06/2018 9:42 AM, Kim Barrett wrote:
>> On Jun 15, 2018, at 11:41 AM, Kevin Walls <kevin.walls at oracle.com> wrote:
>> I'd like to get a review of this backport from 9 to 8u:
>> 8150688: Fix os_windows siglabel
>> 9 changeset:
>> 9 review thread:
>> Proposed 8u change:http://cr.openjdk.java.net/~kevinw/8150688/webrev.00/
> 2228 , def_excpt(EXCEPTION_REG_NAT_CONSUMPTION),
> stray trailing comma.
> Otherwise, looks good. But note that I am not a JDK 8 reviewer (or even committer).
>> This is a pretty clean backport. but didn't import automatically: in 8u
>> there is no "os::get_signal_number()" and some of the def_excpt... lines
>> didn't apply automatically, but they are the same change.
>> This removes some errors when varying the windows compiler in use, still
>> builds and tests OK on current standard VS compiler.
More information about the hotspot-runtime-dev