RFR (S) 8205534: Remove SymbolTable dependency from serviceability agent
jini.george at oracle.com
Fri Jun 29 16:02:02 UTC 2018
Apologize for the delay. Your changes look good to me overall. A few
It might make sense to also remove the corresponding lines in the
vmStructs files. Like:
vmStructs.cpp 170 typedef RehashableHashtable<Symbol*, mtSymbol>
vmStructs.cpp 477 static_field(RehashableSymbolHashtable, _seed,
vmStructs.cpp 1362 declare_type(RehashableSymbolHashtable,
vmStructs.cpp 475 static_field(SymbolTable, _the_table,
vmStructs.cpp 476 static_field(SymbolTable, _shared_table,
You could also remove the "friend class VMStructs" from the
corresponding C++ data types.
The test case: test/jdk/sun/tools/jhsdb/AlternateHashingTest.java with
the file: test/jdk/sun/tools/jhsdb/LingeredAppWithAltHashing.java were
created to test the alternate hashing mechanism of the SymbolTable in
SA. Don't know if it makes sense to retain these.
Line 1079 of HeapHprofBinWriter.java: Extra spaces needed.
On 6/23/2018 3:10 AM, coleen.phillimore at oracle.com wrote:
> Summary: Modify SA code to not use SymbolTable and remove it.
> This is to support the concurrent hashtable for SymbolTable.
> open webrev at http://cr.openjdk.java.net/~coleenp/8205534.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8205534
> Tested with hs-tier1-5.
More information about the hotspot-runtime-dev