RFR (XS): 8199010: attachListener.hpp: Fix potential null termination issue found by coverity scans
christoph.langer at sap.com
Mon Mar 5 15:37:49 UTC 2018
well, I think this discussion is beyond the scope of my contribution. Probably one doesn’t want the risk of JVM crashes/exits just because someone shoots in a bad attach operation name which is too long.
So, may I consider it reviewed from your end? I’m trying the submission repo right now with this change…
From: Thomas Stüfe [mailto:thomas.stuefe at gmail.com]
Sent: Montag, 5. März 2018 15:53
To: Langer, Christoph <christoph.langer at sap.com>
Cc: Hotspot dev runtime <hotspot-runtime-dev at openjdk.java.net>; serviceability-dev at openjdk.java.net
Subject: Re: RFR (XS): 8199010: attachListener.hpp: Fix potential null termination issue found by coverity scans
Seeing that truncation is considered assertion worthy, should we really hide it in release?
On Mar 5, 2018 10:03, "Langer, Christoph" <christoph.langer at sap.com<mailto:christoph.langer at sap.com>> wrote:
please review a small fix that was identified by a coverity code scan.
In case strlen(name) was the same or larger than name_length_max or resp. strlen(arg) >= arg_length_max, the _name or _arg fields would not get null terminated correctly.
More information about the hotspot-runtime-dev