8199319 broke the non-PCH build

Volker Simonis volker.simonis at gmail.com
Mon Mar 12 16:13:52 UTC 2018

On Mon, Mar 12, 2018 at 5:10 PM, Roman Kennke <rkennke at redhat.com> wrote:
>> Finally, I REALLY, REALLY (as I've done for about the last 10 years or
>> so :) advise to add a "non-PCH" build to your secrete, internal
>> JPRT/Mach5 whatsoever HotSpot tests to catch such errors.
> Or can we get rid of PCH altogether? What good does it do anyway? Or
> maybe even just make it the default mode?

I don't want to get rid of the PCH mode because it considerably
improves the build times. PCH is the default on platforms which
support it but not all platforms do.

All that said, the build should be correct WITHOUT PCH because PCH is
a hack which is implemented differently by different compilers.

> Roman

More information about the hotspot-runtime-dev mailing list