RFR(S): 8199532: AbstractMethodErrorTest.java test failed with -Xcomp

David Holmes david.holmes at oracle.com
Wed Mar 14 00:14:16 UTC 2018

Hi Goetz,

On 14/03/2018 7:14 AM, Lindenmaier, Goetz wrote:
> Hi,
> AbstractMethodErrorTest fails with -Xcomp because
> other exception messages are printed if the error happens
> in comiled code.
> I hardened the test.
> Please review:
> http://cr.openjdk.java.net/~goetz/wr18/8199532-fixAmeExMsg/webrev.01/

I expected to see a solution using @requires to exclude Xcomp or other 
obscure modes as Vladimir pointed out.

I think when something like this is so sensitive to the compilation 
environment, that the test needs to maintain complete control. I'd be 
tempted to even simplify the test to expect to be run in either 
interpreted or compiled mode, exclude running the test at all if any 
compiler flags come in via jtreg, and then have explicit @run 
main/othervm for the different scenarios:

- -Xint
- -Xcomp
- non-tiered

Though execution time may be a factor.

And apologies for not thinking about this enough during the review process.


> Best regards,
>    Goetz.

More information about the hotspot-runtime-dev mailing list