RFR (S) 8199272: Broken assertion in ClassLoaderData::remove_handle

Stefan Karlsson stefan.karlsson at oracle.com
Wed Mar 14 08:19:11 UTC 2018

On 2018-03-13 23:53, coleen.phillimore at oracle.com wrote:
> Summary: Added new ClassLoaderData::ChunkList::contains(oop*) function 
> for OopHandle rather than oop (need both)
> Fixed problem found by Stefan in code review for 
> https://bugs.openjdk.java.net/browse/JDK-8198926
> Ran tier1-5 tests in mach5.
> open webrev at http://cr.openjdk.java.net/~coleenp/8199272.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8199272

It might have been good to name this second 'contains' function to 
something else to prevent accidental mixups of the two functions. Maybe 
something like ChunkList::owner_of(oop*):

assert(handles.owner_of(ptr), "Got unexpected handle " PTR_FORMAT, 

Otherwise, this looks good.


> Thanks,
> Coleen

More information about the hotspot-runtime-dev mailing list