RFR(M): 8200126: [TESTBUG] Open source VM runtime signal tests
mikhailo.seledtsov at oracle.com
Wed Mar 28 22:07:38 UTC 2018
Thank you for reviewing the change.
On 03/27/2018 07:03 PM, Christian Tornqvist wrote:
> Hi Misha,
> SigTestDriver.java could use a check for if no argument has been passed on.
It is simple enough, I can add such check. In general, however, when
open sourcing tests, we try to minimize the changes that we do while
open sourcing. For more complex or numerous changes we will file an RFE
or a bug to be addressed later.
> Why aren’t these tests part of the runtime tier1/2/3?
This is the way the tiers were configured for these tests prior to open
sourcing. I can add these tests to tier3.
> Also, do we really need the hotspot_signal test group? These tests are all in the same directory and can easily be executed just by pointing at that directory.
OK, I will remove this group.
>> On Mar 27, 2018, at 9:52 59PM, Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com> wrote:
>> Please review: open sourcing vm signal tests.
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8200126
>> Webrev: http://cr.openjdk.java.net/~mseledtsov/8200126.00.open/
>> 1. Linux-x64:
>> make run-test TEST=hotspot_signal
>> All tests PASS
>> 2. Multi-platform automated testing: Linux-x64, Win-x64, MAC
>> hotspot_signal, hs-tier1, hs-tier2 - in progress
>> Thank you,
More information about the hotspot-runtime-dev