RFR(M): 8200126: [TESTBUG] Open source VM runtime signal tests
david.holmes at oracle.com
Sat Mar 31 07:30:51 UTC 2018
This all seems okay.
On 30/03/2018 12:41 PM, Mikhailo Seledtsov wrote:
> While testing I discovered build errors on Mac and Solaris. The
> following statement " BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exesigtest :=
> -ljvm" was added to a Linux-only block. I have updated the make file to
> add this for any platform w/o conditions; the " exesigtest.c" is
> excluded from Windows anyway down below in the make file. I am not 100%
> sure this is the correct way to modify the make file; if not please
> advise the correct way.
That works for me. I'm not sure how Magnus envisaged this being used
though. An alternative would be:
ifeq ($(OPENJDK_TARGET_OS), windows)
BUILD_HOTSPOT_JTREG_EXECUTABLES_CFLAGS_exeFPRegs := -MT
+ BUILD_HOTSPOT_JTREG_EXCLUDE += exesigtest.c
+ BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exesigtest := -ljvm
but I think your version is more future-proof.
> With this fix all 4 builds pass.
> Here is the updated webrev:
> Thank you,
> On 3/29/18, 4:00 PM, mikhailo wrote:
>> I have addressed feedback from Christian, David and Magnus. Here is
>> the updated webrev:
>> I have also confirmed that output from exesigtest.c printf() is logged
>> into .jtr files.
>> Grepped for "signal", I can see the output such as:
>> TestSigxfsz.jtr:SIGXFSZ: signal handler using function
>> 'sigset' has been set
>> TestSigxfsz.jtr:SIGXFSZ: signal handler for signal 25 has
>> been processed
>> TestSigxfsz.jtr:SIGXFSZ: signal has been sent successfully
>> TestSigxfsz.jtr:SIGXFSZ: signal has been received
>> Also can see other output from the printf, such as all initVM logs.
>> Thank you,
>> On 03/29/2018 02:49 PM, mikhailo wrote:
>>> Thank you for advice. I have updated the makefile accordingly. Will
>>> post updated webrev shortly.
>>> On 03/28/2018 03:26 PM, Magnus Ihse Bursie wrote:
>>>> Yes, you seem to have based this off an old version of
>>>> If you update the file I think you see how you should do it, but
>>>> I'll give you some help:
>>>> ifeq ($(OPENJDK_TARGET_OS), windows)
>>>> BUILD_HOTSPOT_JTREG_EXECUTABLES_CFLAGS_exeFPRegs := -MT
>>>> BUILD_HOTSPOT_JTREG_EXCLUDE += exesigtest.c
More information about the hotspot-runtime-dev