RFR (M) 8209946 [TESTBUG] CDS tests should use "@run driver"

Ioi Lam ioi.lam at oracle.com
Mon Oct 1 23:10:40 UTC 2018

On 10/1/18 2:23 PM, Calvin Cheung wrote:
> Hi Ioi,
> Changes look good.
> Just noticed that appcds/cacheObject/DifferentHeapSizes.java contains 
> only copyright changes.
Hi Calvin, thanks for the review. DifferentHeapSizes.java  was fixed my 
script that was looking for copyright formatting errors. We are missing 
a required "," after the year 2018. I thought I'll just include it in 
this patch instead of creating a new bug report.

- Ioi

> thanks,
> Calvin
> On 10/1/18, 10:18 AM, Ioi Lam wrote:
>> Hi,
>> Please review this cleanup. It touches a lot of files, but the 
>> changes are
>> simple and were done by a script (see bug report).
>> https://bugs.openjdk.java.net/browse/JDK-8209946
>> http://cr.openjdk.java.net/~iklam/jdk12/8209946-cds-test-use-run-driver.v01/ 
>> Most CDS tests are currently using "@run main" to run the main class.
>> However, the main class is usually just a "script" that prepares JAR 
>> files and
>> launches child JVM processes that do the real testing (create or use CDS
>> archives). Usually, the main class itself is not the subject of the 
>> test.
>> According to http://openjdk.java.net/jtreg/faq.html, we should use 
>> "@run driver".
>> I am validating the changes with hs-tier{1,2,3} tests.
>> Thanks
>> - Ioi

More information about the hotspot-runtime-dev mailing list