RFR 8017061: os_bsd.cpp contains code for UseSHM and UseHugeTLBFS

David Holmes david.holmes at oracle.com
Tue Oct 16 06:48:45 UTC 2018

Hi Gerard,

On 16/10/2018 5:41 AM, Gerard Ziemski wrote:
> Hi all,
> Please review this small fox that removes code from bsd platform, which implements unused (and untested) UseLargePages support.

Removal seems okay but I think you can also remove:

./os/bsd/globals_bsd.hpp:  product(bool, UseSHM, false,
./os/bsd/globals_bsd.hpp:  product(bool, UseHugeTLBFS, false,

> Also, in this fix, I took opportunity to cleanup OS includes (there were unused and duplicated headers)

Seems mostly okay but I would have expected mach/mach.h, or 
mach/mach_time.h, to get mach_timebase_info_data_t ? Maybe it comes in 
indirectly from elsewhere? I poked around the devkit but couldn't 
isolate it.


> Bug: https://bugs.openjdk.java.net/browse/JDK-8017061
> Webrev: http://cr.openjdk.java.net/~gziemski/8017061_rev1
> Testing: passes Mach5 hs_tier1-7
> Cheers

More information about the hotspot-runtime-dev mailing list