RFR 8017061: os_bsd.cpp contains code for UseSHM and UseHugeTLBFS

Gerard Ziemski gerard.ziemski at oracle.com
Wed Oct 17 17:14:17 UTC 2018

Thank you for your reviews.

> On Oct 16, 2018, at 6:52 PM, David Holmes <david.holmes at oracle.com> wrote:
> Hi Gerard,
> On 17/10/2018 2:04 AM, Gerard Ziemski wrote:
>> hi David,
>> Thank you for the review.
>>> On Oct 16, 2018, at 1:48 AM, David Holmes <david.holmes at oracle.com> wrote:
>>> Hi Gerard,
>>> On 16/10/2018 5:41 AM, Gerard Ziemski wrote:
>>>> Hi all,
>>>> Please review this small fox that removes code from bsd platform, which implements unused (and untested) UseLargePages support.
>>> Removal seems okay but I think you can also remove:
>>> ./os/bsd/globals_bsd.hpp:  product(bool, UseSHM, false,
>>> ./os/bsd/globals_bsd.hpp:  product(bool, UseHugeTLBFS, false,
>> If I remove “UseSHM” and “UseHugeTLBFS” they will stop being accepted on BSD platform, though the documentation says it’s Linux only. Would I need to obsolete them? If so, how to obsolete a flag on just one platform?
> I think if you #ifdef the entry in the obsolete flags table that would do it. This is a rare occurrence. Obsolete in 12 and expire in 13.


Webrev: http://cr.openjdk.java.net/~gziemski/8017061_rev2
Testing: Mach5 hs_tier1-6 underway…


More information about the hotspot-runtime-dev mailing list