RFR (S): 8199567: [Nestmates] Cleanup instanceKlass.cpp
lois.foltan at oracle.com
Tue Oct 23 14:20:31 UTC 2018
On 10/23/2018 8:36 AM, David Holmes wrote:
> Hi Lois,
> On 23/10/2018 10:14 PM, Lois Foltan wrote:
>> On 10/22/2018 11:43 PM, David Holmes wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8199567
>>> Webrev: http://cr.openjdk.java.net/~dholmes/8199567/webrev/
>>> This is a simple "cleanup" previously suggested by John Rose for
>>> checking nest membership. Rather than checking for name equality and
>>> then checking the loaded class, we check if there's a loaded class
>>> first and if not fallback to the name check. This favours the case
>>> where the nestmate classes are already resolved and loaded.
>> Hi David,
>> Looks good. One comment:
> Thanks for looking at it!
>> - line #173: Consider changing the if conditional to "if
>> I believe the "is_klass()" method is the preferred way to compare a
>> tag to JVM_CONSTANT_Class.
> Sure - webrev updated:
Looks good, thank you for making that change!
>>> There was no observable performance difference.
>>> Testing: mach5 tiers 1-3 including nestmate tests
More information about the hotspot-runtime-dev