RFR(XS): 8212220 add code to verify results to metaspace/stressDictionary/StressDictionary.java
Daniel D. Daugherty
daniel.daugherty at oracle.com
Tue Oct 23 19:20:51 UTC 2018
On 10/23/18 11:57 AM, Daniel D. Daugherty wrote:
> The following test has been timing out intermittently in the
> jdk/jdk CI lately:
> Those failures are being tracked by the following bug:
> vmTestbase/metaspace/stressDictionary/StressDictionary.java timeout
> While investigating the timeouts, I noticed that the test is not doing
> explicit verification of the results from the ExecutorService so I have
> added code to do that.
> With the fix for JDK-8212028 in place, the test is timing out much more
> frequently in the jdk/jdk CI; the total timeout for the test went from
> 20 minutes down to 8 minutes. I have changed the default timeout value
> for the test to 5 minutes (from 2 minutes) and with the new default
> TIMEOUT_FACTOR of 4 (was 10), the total timeout for the test will be
> restored to 20 minutes.
> The total timeout changes will allow the new results verification code
> to be used in the infrequent 20 minute timeout cases that we originally
> saw when JDK-8211211 was filed.
> Here's the URL for the test changes:
> Here's the sub-task bug ID for the test changes:
> JDK-8212220 add code to verify results to
> I'm currently running the revised test thru the Mach5 system:
> It's a bit of overkill, but I don't know how much of the timeout
> is being caused by test system load so I'm trying to replicate
> what is being done by the jdk/jdk CI system.
> Thanks, in advance, for any comments, questions or suggestions.
Made one minor tweak to the new code:
$ diff 8211211.diff.debug.txt.01 8211211.diff.debug.txt.03
< + System.out.println("INFO: There are " + act_results + "
> + System.err.println("INFO: There are " + act_results + "
< + System.out.println("INFO: no tasks were cancelled.");
> + System.err.println("INFO: no tasks were cancelled.");
< + System.out.println("INFO: all tasks are done.");
> + System.err.println("INFO: all tasks are done.");
During testing, the new "INFO" lines were getting lost in JTREG
output truncation for System.out so I've moved the new INFO lines
More information about the hotspot-runtime-dev