RFR(tedius) 8229267 [TESTBUG] Remove unnecessary @module dependencies in CDS tests

Ioi Lam ioi.lam at oracle.com
Fri Aug 9 16:33:23 UTC 2019

Hi Alan & Lois,

Thanks for the review.

Alan - yes, many of the unnecessary dependencies were added when the 
@modules tag was introduced in JDK9. At that time, the test 
infrastructure had many unnecessary dependencies. I guess it wasn't easy 
to fix all of the test libraries at once, so instead we added enough 
@modules tags just to keep the tests running.

Unfortunately, when the test libraries are fixed (e.g., [1]), we didn't 
follow up with fixing the tests. Later, when new tests are created by 
cut-and-paste, the unnecessary @modules tag keeps propagating :-(

- Ioi

[1] https://bugs.openjdk.java.net/browse/JDK-8164944
     Refactor ProcessTools to get rid of dependency on java.management

On 8/9/19 3:10 AM, Alan Bateman wrote:
> On 09/08/2019 02:31, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8229267
>> http://cr.openjdk.java.net/~iklam/jdk14/8229267-remove-unncessary-at-modules-from-cds-tests.v01/ 
>> We have lots of unnecessary @modules tags in the hotspot test cases. 
>> I wrote a script that
>> attempts to remove each specified module.
> This changes look okay to me. It may be that these tags are left over 
> from when test infrastructure used by these tests was using 
> sun.tools.jar to create JAR files. The dependency on jdk.internal.misc 
> may have been something in the test infrastructure using the internal 
> Unsafe API.
> -Alan

More information about the hotspot-runtime-dev mailing list