RFR(S) 8226645: [TESTBUG] some AppCDS tests relies on illegal reflective access
calvin.cheung at oracle.com
Thu Aug 15 17:25:59 UTC 2019
On 8/14/19 3:14 AM, David Holmes wrote:
> This is much clearer to me now.
> On 14/08/2019 4:32 pm, Alan Bateman wrote:
>> On 14/08/2019 01:32, Calvin Cheung wrote:
>>> Updated webrev:
>>> Summary of changes:
>>> - test case provides a lookup instance to Util.defineModifiedClass;
>>> - implemented URLClassLoader.loadClass method in LoaderSegregation
>>> so no need to use Util.defineClassFromJAR;
>>> - removed Util.defineClassFromJAR.
>> Can you fix the defineModifiedClass's method description? The comment
>> talks about "peerClass" which I think is left over from a previous
>> In LoaderSegregationTest it might be better to list
>> LoaderSegregation$1 after its enclosing class.
>> The rest looks good to me.
More information about the hotspot-runtime-dev