RFR (trivial): 8229808: javaVFrame::print_lock_info_on fails to disable extra printing

Harold Seigel harold.seigel at oracle.com
Fri Aug 16 11:51:35 UTC 2019

Looks good and trivial.

Thanks, Harold

On 8/16/2019 2:53 AM, David Holmes wrote:
> bug: https://bugs.openjdk.java.net/browse/JDK-8229808
> webrev: http://cr.openjdk.java.net/~dholmes/8229808/webrev/
> Trivial code cleanup that Stefan noticed. The original code with 
> disabled printing was added in JDK-8069412 using the Verbose flag 
> combined with a non-NULL mark. The use of the verbose flag was 
> replaced by ObjectMonitor::Knob_verbose in JDK-8130448. Then the 
> printing code was removed by JDK-8210848 "Obsolete SyncKnobs" - at 
> which point the comment about "disable extra printing below" should 
> also have been removed, and the mark variable returned to being local 
> to the if-clause. There's also an earlier comment relating to lockbits 
> that refers to the printing code that was deleted, so its gone too.
> Thanks,
> David

More information about the hotspot-runtime-dev mailing list