RFR: 8230043: Lazily load libverify
harold.seigel at oracle.com
Mon Aug 26 13:42:33 UTC 2019
It looks good.
On 8/23/2019 2:03 PM, Claes Redestad wrote:
> Hi Harold,
> On 2019-08-23 18:43, Harold Seigel wrote:
>> Hi Claes,
>> thanks for doing this.
> thanks for looking at this!
>> I have a couple of questions.
>> 1. Is line 87 in verifier.cpp trying to load libverify, if so, why?
>> 87 if (!os::dll_locate_lib(buffer, sizeof(buffer),
>> Arguments::get_dll_dir(), "verify"))
> No, this method just calculates the real name of the verify lib, fills
> it into buffer and verifies the library file exists (stat syscall).
> os::dll_load on line 90 does the actual load.
>> 2. Did the change intend to remove the SerializePage_lock from
>> mutexLocker.cpp ?
>> 3. Did the change intend to remove mutex ParkerFreeList_lock from
>> mutexLocker.hpp ?
> Yes and yes, since it's dead code, but I can leave it alone if you
More information about the hotspot-runtime-dev