RFR(S/L): 8230184 rename, whitespace, indent and comments changes in preparation for lock free Monitor lists

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Aug 28 16:47:25 UTC 2019


Looks like I left a change in the v2.06c patch for JDK-8153224 when I
extracted the changes for JDK-8230184:

$ hg diff
diff -r e17f768b3b71 
--- a/test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java Wed 
Aug 28 10:56:50 2019 -0400
+++ b/test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java Wed 
Aug 28 12:41:35 2019 -0400
@@ -59,7 +59,7 @@
-                    "ObjectSynchronizer::gBlockList",
+                    "ObjectSynchronizer::g_block_list",
              expStrMap.put("printstatics SystemDictionary", List.of(
                      "Static fields of SystemDictionary",

I'm using the following bug to push this trivial fix:

     JDK-8230317 serviceability/sa/ClhsdbPrintStatics.java fails after 

I verified that the test now passes on my Linux-X64 server in a repo 
with 8230184
plus this one liner change.

May I please have a single (R)eviewer?


On 8/27/19 6:29 PM, Daniel D. Daugherty wrote:
> Greetings,
> This is my first set of JDK14 baseline cleanup changes extracted from the
> Async Monitor Deflation project (JDK-8153224).
> This is an "S" review because it is conceptually Small. It is also an "L"
> review because it has a mind numbingly Large number of cleanup changes.
> Coleen, should appreciate this one since it takes care of a number of
> naming issues that she (and others) have wanted to see fixed for years.
> As usual, the bug report has a yacky description of what I'm cleaning up
> this round and why:
>    JDK-8230184 rename, whitespace, indent and comments changes in 
> preparation
>                for lock free Monitor lists
>    https://bugs.openjdk.java.net/browse/JDK-8230184
> Here's the webrev URL:
>     http://cr.openjdk.java.net/~dcubed/8230184-webrev/0_for_jdk14/
> This webrev is relative to jdk-14+11.
> This fix is included in my latest round of JDK-8153224 testing which
> included Mach5 Tier[1-8], my stress kit on Linux-X64 and Solaris-X64,
> my Inflate2 test running in parallel with Kitchensink8H on macOSX,
> Linux-X64 and Solaris-X64. I also ran the Inflate2 and Kitchensink8H
> combo in parallel on the jdk-14+11 baseline + this fix on macOSX,
> Linux-X64 and Solaris-X64. No regressions were observed in any of
> the testing.
> Thanks, in advance, for any comments, suggestions or questions.
> Dan

More information about the hotspot-runtime-dev mailing list