RFR(L): 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
robin.westberg at oracle.com
Tue Jul 2 15:20:20 UTC 2019
Looks good to me!
Very minor nits:
> On 2 Jul 2019, at 15:08, Markus Gronlund <markus.gronlund at oracle.com> wrote:
> Thank you Erik for the review.
> Can I please ask for a second reviewer?
> -----Original Message-----
> From: Erik Gahlin
> Sent: den 1 juli 2019 16:49
> To: Markus Gronlund <markus.gronlund at oracle.com>
> Cc: hotspot-jfr-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
> Subject: Re:  RFR(L): 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
> Looks good.
>> On 28 Jun 2019, at 17:56, Markus Gronlund <markus.gronlund at oracle.com> wrote:
>> Kindly asking for reviews for the following changeset:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8214542
>> Webrev: http://cr.openjdk.java.net/~mgronlun/8214542/webrev01/
>> Testing: test/jdk/:jdk_jfr
>> Removal of heavy current_frontier assertion.
>> Trimmed down storage requirements by only storing necessary contextual edges.
>> Normalized representation of edges for better reuse.
>> Better preservation of already persisted tree structure by less intrusive reuse logic.
>> Thank you in advance
More information about the hotspot-runtime-dev