RFR [S]: 8227527: LogDecorations should lazily resolve host name

Thomas Stüfe thomas.stuefe at gmail.com
Wed Jul 10 20:15:53 UTC 2019

Hi Claes,

This looks all very good.

My only remark is not directed at your patch, but I would prefer diagnostic
code like logging not to crash at a native OOM (I refer to the strdup), but
rather handle it gracefully, e.g. by just printing "???" as hostname.

Cheers, Thomas

On Wed, Jul 10, 2019, 16:55 Claes Redestad <claes.redestad at oracle.com>

> Hi,
> reportedly the uname syscall taken to initialize logDecorations can
> carry a small but measurable startup cost on some systems/platforms, so
> the not-used-by-default _host_name should be lazily initialized.
> Webrev:  http://cr.openjdk.java.net/~redestad/8227527/open.00/
> Bug:     https://bugs.openjdk.java.net/browse/JDK-8227527
> Testing: t1-3
> Thanks!
> /Claes

More information about the hotspot-runtime-dev mailing list