RFR(S): 8227597: [fastdbg build] Arena::inc_bytes_allocated should get inlined
goetz.lindenmaier at sap.com
Fri Jul 12 08:26:09 UTC 2019
thanks for looking at the timeouts we get with the jtreg tests
on ppc. Inlining inc_bytes_allocated looks like a step forward.
But why do you remove the #if in inc_stat_counter()?
It is not there because it's not implemented on other platforms,
but because SPARC and X86 have (had) 32-bit variants.
Actually, your change should slow down the code on
PPC & others.
I think the right #define here is #ifndef LP64.
And you now need that in inc_bytes_allocated, too.
> -----Original Message-----
> From: Doerr, Martin
> Sent: Donnerstag, 11. Juli 2019 17:32
> To: hotspot-runtime-dev at openjdk.java.net
> Cc: Baesken, Matthias <matthias.baesken at sap.com>; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>; Claes Redestad <claes.redestad at oracle.com>
> Subject: RFR(S): 8227597: [fastdbg build] Arena::inc_bytes_allocated should
> get inlined
> the simple function Arena::inc_bytes_allocated can be found as CPU consuming
> when profiling the fastdbg build. It is located in a cpp file.
> It should better get inlined to improve the performance of the fastdbg VM
> which is important for complex tests.
> In addition, atomic 8-Byte load and store functions are available on all
> platforms, so the "#if defined ..." can get removed.
> Here's my proposal:
> Feedback is welcome.
> Best regards,
More information about the hotspot-runtime-dev