RFR(xs): 8220151: SafepointTracing::end_of_last_safepoint_ms should return ms since epoch.

David Holmes david.holmes at oracle.com
Tue Mar 5 12:10:19 UTC 2019

Hi Robbin,

On 5/03/2019 9:58 pm, Robbin Ehn wrote:
> Hi all, please review.
> os::javaTimeNanos and os::javaTimeMillis may use different starting points.

They are completely unrelated except in the most degenerate of cases on 
a system with no high-res clock.

> nanos cannot be converted to millies when comparing to absolute ms time.


> SafepointTracing::end_of_last_safepoint_ms must use os::javaTimeMillis.

If it's intended to be a timestamp then yes.

> Code:
> http://cr.openjdk.java.net/~rehn/8220151/webrev/
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8220151

Looks fine to me.


> Passes t1.
> Thanks, Robbin

More information about the hotspot-runtime-dev mailing list