RFR: 8219860: Cleanup ClassFileParser::parse_linenumber_table

Claes Redestad claes.redestad at oracle.com
Fri Mar 8 10:45:27 UTC 2019

Hi Robbin,

On 2019-03-08 11:34, Robbin Ehn wrote:
> Hi Claes.
> Removes 4 times more than it adds, great!
> It seems very reasonably.


> Very minor nit, I would remove TRAPS from get_u1(TRAPS) if it's not 
> needed, and I can't see that it is. Keep it if you think it makes some 
> sense.

I think it might be necessary for the exception handling down that
path, which is admittedly a bit hairy. Either way I've just moved this
pre-existing method to help with inlining and would like to keep this
cleanup from spiraling off in yet another direction. :)


More information about the hotspot-runtime-dev mailing list