RFR: 8233454: Test fails with assert(!is_init_completed(), "should only happen during init") after JDK-8229516
fujie at loongson.cn
Tue Nov 5 02:49:39 UTC 2019
I had tested your patch (without the Shenandoah fix) on VMs with/without
the JRF feature and both of them had passed for the particular reproducer.
So thanks again for fixing it in the shared runtime code.
On 2019/11/5 上午7:26, David Holmes wrote:
> Hi Jie,
> Thanks for filing this and attempting a fix. As per the bug report the
> underlying issue has now been fixed in Shenandoah, but I want to make
> the interrupt code more resilient as well:
> I was unable to reproduce the Shenandoah crash so if you could test
> this patch I would appreciate it - thanks. (Without the Shenandoah fix
> of course :) )
> Meanwhile I'm putting the patch through other testing.
> On 4/11/2019 11:13 pm, David Holmes wrote:
>> Hi Jie,
>> I will need to take a deeper look at this. This is a problem specific
>> to Shenadoah GC as it is triggering a sleep whilst a thread is still
>> in the process of attaching to the JVM :(
>> On 4/11/2019 7:16 pm, Jie Fu wrote:
>>> Hi all,
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8233454
>>> Webrev: http://cr.openjdk.java.net/~jiefu/8233454/webrev.00/
>>> According to the comment , the assert seems to miss the case for
>>> threads attached via JNI.
>>> For more info, please refer to the JBS.
>>> Could you please review it and give me some advice?
>>> Thanks a lot.
>>> Best regards,
More information about the hotspot-runtime-dev