RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

mark.reinhold at oracle.com mark.reinhold at oracle.com
Wed Oct 2 22:40:45 UTC 2019

2019/10/2 5:45:10 -0700, goetz.lindenmaier at sap.com:
> thanks for looking at my change! Can I add you as reviewer?


>> This is very nice work!  I especially appreciate the thorough tests.
> Thanks!  But adapting the many tests to changed messages is 
> quite cumbersome :) Thanks for supplying the patch right away!

Nothing that a little Emacs-fu can’t handle.

>> ...
>> I also noticed that the generated messages use single quotes (‘'’) to
>> quote the names of fields, etc., rather than double quotes (‘"’).
> I'm fine with this, but I think hotspot uses "'" for citing code
> quite consistently. E.g., have a look at 
> http://hg.openjdk.java.net/jdk/jdk/file/b25362cec8ce/src/hotspot/share/interpreter/linkResolver.cpp
> This can easily be changed.  I could do a separate change 
> for hotspot and change all uses of ' in exceptions to ". What 
> do you think?

I think that’d be a fine clean-up task, for later.

- Mark

More information about the hotspot-runtime-dev mailing list