RFR (XS/T) 8231930: Windows build fails after JDK-8191521

Schmelter, Ralf ralf.schmelter at sap.com
Tue Oct 8 08:18:02 UTC 2019

Hi Aleksey,

looks good. I assume you compile with VS2010 or VS2013?

Best regards,

-----Original Message-----
From: Aleksey Shipilev <shade at redhat.com> 
Sent: Montag, 7. Oktober 2019 12:47
To: hotspot-runtime-dev at openjdk.java.net
Cc: Schmelter, Ralf <ralf.schmelter at sap.com>
Subject: RFR (XS/T) 8231930: Windows build fails after JDK-8191521



diff -r 97cd0aa39787 test/hotspot/gtest/runtime/test_os_windows.cpp
--- a/test/hotspot/gtest/runtime/test_os_windows.cpp    Mon Oct 07 07:53:38 2019 +0200
+++ b/test/hotspot/gtest/runtime/test_os_windows.cpp    Mon Oct 07 12:45:10 2019 +0200
@@ -355,5 +355,5 @@
   if (convert_to_cstring(buf, JVM_MAXPATHLEN, path)) {
     ::testing::Test::RecordProperty(name, buf);
-    snprintf(buf, JVM_MAXPATHLEN, "%d", (int) wcslen(path));
+    os::snprintf(buf, JVM_MAXPATHLEN, "%d", (int) wcslen(path));
     ::testing::Test::RecordProperty(len_name, buf);

This follows the relevant Windows build fixes: we use os::snprintf [1].

Testing: windows build, gtest:os (runs affected test)


[1] https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2019-February/032806.html

More information about the hotspot-runtime-dev mailing list