RFR: 8170299: Debugger does not stop inside the low memory notifications code
daniil.x.titov at oracle.com
Tue Oct 8 18:07:09 UTC 2019
Hi David and Serguei,
Thank you for reviewing this fix!
On 10/2/19, 4:24 PM, "serguei.spitsyn at oracle.com" <serguei.spitsyn at oracle.com> wrote:
I also prefer (agree with) a new VM option to opt-out from the new behavior.
Sorry for some latency in the review and discussion process.
On 10/1/19 20:20, David Holmes wrote:
> Hi Daniil,
> Thanks again for your perseverance with this one.
> This looks fine to me.
> On 2/10/2019 6:57 am, Daniil Titov wrote:
>> Please review a new version of the change  that fixes the problem
>> with the debugger not stopping in the low memory notification code.
>> The fix moves the send notifications task from
>> not visible ServiceThread to a new visible NotificationThread. This
>> version of the change also introduces a new VM option to opt-out
>> from the new behavior.
>> Previous email threads:
>> The proposed CSR  is for adding a new VM option
>> UseNotificationThread (default true) to opt-out from the new behavior.
>> Testing: Mach5 tests tier1, tier2, tier3, and tier7 successfully passed.
>>  Webrev: http://cr.openjdk.java.net/~dtitov/8170299/webrev.05/
>>  Bug: https://bugs.openjdk.java.net/browse/JDK-8170299
>>  CSR: https://bugs.openjdk.java.net/browse/JDK-8231593
More information about the hotspot-runtime-dev