RFR(XL): 8220310: Implementation: NUMA-Aware Memory Allocation for G1, Mutator (1/3)

Kim Barrett kim.barrett at oracle.com
Mon Oct 14 21:31:01 UTC 2019

> On Oct 14, 2019, at 5:03 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> I also missed that there seems to be a units mismatch in the call to
> request_memory_on_node in G1RegionsSmallerThanCommitSizeMapper. It's
> passing a region index rather than a page index (before above change)
> or address (after above change).

That’s wrong; there are some problematic variable namings here.  start_idx is a
heap region index, idx is a page index.  Sangheon and I discussed this offline
and he’s planning to change some variable names here.

More information about the hotspot-runtime-dev mailing list