RFR: 8232211: Remove dead code from os.hpp|cpp

David Holmes david.holmes at oracle.com
Wed Oct 16 02:37:56 UTC 2019

Hi Claes,

On 16/10/2019 12:00 am, Claes Redestad wrote:
> Hi,
> Robbin pointed out a few additional things that seemed to be unused,
> including an unused createThread_lock Mutex

Ha! Yet another remnant of the ancient LinuxThreads support.

> and that _os_version is
> never read, which means initialize_os_info can go - too.

Hmmmm. This is the kind of information that could be used then not used 
then used again on each release, depending on whether we introduce or 
remove code that is conditional on the OS version. I guess we can always 
add it back ... though I'm willing to bet that if we need this again the 
person making the change will reinvent the code rather than resurrecting 
it. :(


> New webrev: http://cr.openjdk.java.net/~redestad/8232211/open.01/
> Incremental: http://cr.openjdk.java.net/~redestad/8232211/open.00_01.inc/
> Testing: I'll get some done...
> Thanks!
> /Claes
> On 2019-10-15 14:28, Claes Redestad wrote:
>> Hi,
>> feel free to review this patch which simply removes a number of
>> dead and/or effectively unused methods from our os interface
>> Webrev: http://cr.openjdk.java.net/~redestad/8232211/open.00/
>> Bug:    https://bugs.openjdk.java.net/browse/JDK-8232211
>> Testing: tier1-2,5 (includes minimal VM builds)
>> Thanks!
>> /Claes

More information about the hotspot-runtime-dev mailing list