RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.
goetz.lindenmaier at sap.com
Thu Oct 17 07:15:22 UTC 2019
Finally jdk/submit completed. I'll push now.
I would like to update the JEP text with the latest
changes to the message, also I would like to persist
the example file in JBS.
Do you think it is ok to still modify the JBS issue?
Once more many, many thanks for your help in
driving the JEP forward, I would never have made
it without you!
> -----Original Message-----
> From: hotspot-runtime-dev <hotspot-runtime-dev-bounces at openjdk.java.net>
> On Behalf Of coleen.phillimore at oracle.com
> Sent: Mittwoch, 16. Oktober 2019 01:21
> To: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR (L, final): 8218626: Add detailed message to
> NullPointerException describing what is null.
> Looks good!
> On 10/14/19 9:46 AM, Lindenmaier, Goetz wrote:
> > Hi everybody,
> > JEP 358 is targeted to jdk14.
> > If there are no objections, I'll push this change tomorrow or
> > on Wednesday.
> > I'll do one final pass of jdk/submit before pushing.
> > The final webrev:
> > http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/21/
> > Best regards,
> > Goetz.
> >> -----Original Message-----
> >> From: mark.reinhold at oracle.com <mark.reinhold at oracle.com>
> >> Sent: Donnerstag, 3. Oktober 2019 00:41
> >> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> >> Cc: hotspot-runtime-dev at openjdk.java.net; core-libs-dev at openjdk.java.net
> >> Subject: Re: RFR (L, final): 8218626: Add detailed message to
> >> NullPointerException describing what is null.
> >> 2019/10/2 5:45:10 -0700, goetz.lindenmaier at sap.com:
> >>> thanks for looking at my change! Can I add you as reviewer?
> >> Sure.
> >>>> This is very nice work! I especially appreciate the thorough tests.
> >>> Thanks! But adapting the many tests to changed messages is
> >>> quite cumbersome :) Thanks for supplying the patch right away!
> >> Nothing that a little Emacs-fu can’t handle.
> >>>> ...
> >>>> I also noticed that the generated messages use single quotes (‘'’) to
> >>>> quote the names of fields, etc., rather than double quotes (‘"’).
> >>> I'm fine with this, but I think hotspot uses "'" for citing code
> >>> quite consistently. E.g., have a look at
> >> preter/linkResolver.cpp
> >>> This can easily be changed. I could do a separate change
> >>> for hotspot and change all uses of ' in exceptions to ". What
> >>> do you think?
> >> I think that’d be a fine clean-up task, for later.
> >> - Mark
More information about the hotspot-runtime-dev