[8u] RFR (XS) 8231398: Add time tracing for gc log rotation at safepoint cleanup
Andrew John Hughes
gnu.andrew at redhat.com
Thu Oct 31 12:42:20 UTC 2019
On 01/10/2019 11:16, Aleksey Shipilev wrote:
> Thanks Paul.
> I'll wait for 8u approval now.
> On 9/25/19 7:35 PM, Hohensee, Paul wrote:
>> Looks good.
>> On 9/24/19, 1:17 AM, "hotspot-runtime-dev on behalf of Aleksey Shipilev" <hotspot-runtime-dev-bounces at openjdk.java.net on behalf of shade at redhat.com> wrote:
>> There is a nice gotcha when dealing with low latency workloads. The safepoint cleanup does lots of
>> things, notably rotating the GC logs in 8 (fixed by transition to Unified Logging in 9+, see
>> JDK-8145092). Those things are normally caught by -XX:+TraceSafepointCleanupTime, but not gc log
>> rotation, since it misses the tracing statement.
>> We should consider adding the tracing there.
>> Testing: eyeballing safepoint cleanup tracing, tier1 (running)
I was expecting this to be more convoluted from the description, but
certainly have no problem with this one-liner :) Certainly don't want to
be backporting something like JDK-8145092.
Looks good and approved.
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
More information about the hotspot-runtime-dev