RFR (XS) 8232734 [TESTBUG] avoid using JDK symbols in ExtraSymbols.symbols.txt
ioi.lam at oracle.com
Thu Oct 31 21:56:15 UTC 2019
Thanks for the review.
I'll add two more test cases:
appendSymbol(fw, ""); // empty string
The generated config file looks like this:
5 -1: Hello
7 -1: Hello_\x01
8 -1: Hello_\xc3\xbf
9 -1: Hello_\xe1\x88\xb4
9 -1: Hello_\xef\xbf\xbf
10 -1: NewSymbol0
10 -1: NewSymbol1
10 -1: NewSymbol2
On 10/31/19 12:27 PM, Calvin Cheung wrote:
> Hi Ioi,
> The removed ExtraSymbols.symbols.txt contains a zero-length symbol as
> 0 -1:
> Maybe the above could be added in ExtraSymbols.makeLotsExtraSymbols()?
> Looks good otherwise.
> On 10/30/19 7:33 PM, Ioi Lam wrote:
>> ExtraSymbols.symbols.txt contains symbols that were once
>> extracted from the JDK. This has caused confusion when
>> developers are removing APIs from the JDK, and they are not
>> sure if they should also remove the corresponding symbols in
>> this file.
>> In this patch, ExtraSymbols.symbols.txt is removed altogether. Instead,
>> a text file is generated at run time to cover the necessary cases.
>> Tested with hs-tier1/2.
>> - Ioi
More information about the hotspot-runtime-dev