RFR (S) 8238289: Use _byteswap_ functions to implement Bytes::swap_uX on Windows

Yumin Qi yumin.qi at oracle.com
Fri Apr 3 20:34:28 UTC 2020

Hi. Ralf

   The fix makes sense for Windows. I think it is a trivial fix.


On 4/3/20 1:40 AM, Schmelter, Ralf wrote:
> Hi,
> can you please review this change. It uses the VS compiler intrinsics to implement byte order swapping for 16, 32 and 64 bit types. For most other platforms we already used the platform specific calls to do this.
> bugreport: https://bugs.openjdk.java.net/browse/JDK-8238289
> webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8238289/webrev.0/
> As a consequence of this change the size of the server.dll increased by ~ 7kB for a release build. This was not expected, since the code needed for a implementation of the byte swap calls itself was much smaller now. In the end I've traced it down to more inlining being done in the JFR code.
> Best regards,
> Ralf

More information about the hotspot-runtime-dev mailing list