RFR(XXS): 8242485: Null _file checking in fileStream::flush()

David Holmes david.holmes at oracle.com
Fri Apr 10 22:53:39 UTC 2020


On 10/04/2020 10:34 pm, Denghui Dong wrote:
> Hi team,
> Could you please review this small patch?
> JBS: https://bugs.openjdk.java.net/browse/JDK-8242485
> webrev: http://cr.openjdk.java.net/~ddong/8242485/webrev.00/
> I found the method "fileStream::flush()" lacks null check before fflush  which will cause
> all open output streams are flushed by fflush() if _file is NULL.

Good catch. Our fileStream abstraction seems somewhat broken when it 
comes to errors! I think fileStream::readln also needs a NULL check for 
clarity if nothing else.


> Thanks,
> Denghui Dong

More information about the hotspot-runtime-dev mailing list