RFR (trivial & urgent) 8242913: Bump the SPECIAL_FLAG_VALIDATION_BUILD to 25
david.holmes at oracle.com
Thu Apr 16 07:29:02 UTC 2020
On 16/04/2020 4:42 pm, Aleksey Shipilev wrote:
> On 4/16/20 8:35 AM, David Holmes wrote:
>> Arguments::verify_special_jvm_flags is used to check the
>> validity/integrity of the special flags table e.g. to check that
>> obsolete and expired flags get removed in the release they are supposed
>> to. This is called from a gtest. To prevent this validity test from
>> failing as soon as we bump the release value, and to allow a grace
>> period for the actual obsoletion/expiration to take place, we only
>> trigger the failure once we hit a specific build number. This number was
>> initially set at 20 based on the total of 33 builds for JDK 13.
>> Today we hit build 20 of JDK 15 and there is still an outstanding issue
>> to obsolete the MonitorBound flag - JDK-8230940. As that issue needs a
>> little more time to complete, and because of the noise the test failure
>> causes in the Oracle CI testing framework, the build number will be
>> bumped to 25.
>> Diff below.
>> diff -r d5de6e540eaf src/hotspot/share/runtime/arguments.cpp
>> --- a/src/hotspot/share/runtime/arguments.cpp
>> +++ b/src/hotspot/share/runtime/arguments.cpp
>> @@ -720,13 +720,13 @@
>> // is updated as it occurs for every test and some tests are not
>> prepared to handle
>> // unexpected output - see 8196739. Instead we only check if the table
>> is up-to-date
>> // if the check_globals flag is true, and in addition allow a grace
>> period and only
>> -// check for stale flags when we hit build 20 (which is far enough into
>> the 6 month
>> +// check for stale flags when we hit build 25 (which is far enough into
>> the 6 month
>> // release cycle that all flag updates should have been processed,
>> whilst still
>> // leaving time to make the change before RDP2).
>> // We use a gtest to call this, passing true, so that we can detect
>> stale flags before
>> // the end of the release cycle.
>> -static const int SPECIAL_FLAG_VALIDATION_BUILD = 20;
>> +static const int SPECIAL_FLAG_VALIDATION_BUILD = 25;
> Looks fine and trivial.
More information about the hotspot-runtime-dev