RFR 8242484: Rework thread deletion during VM termination
david.holmes at oracle.com
Fri Apr 17 01:49:39 UTC 2020
Sorry I thought I had replied to this straight away.
On 15/04/2020 6:07 am, Patricio Chilano wrote:
> Please review this small follow up for 8240918 to always delete the
> JavaThread that calls Threads::destroy_vm().
> In 8240918 I added a conditional check in Threads::destroy_vm() to
> prevent deleting a JavaThread when there are handshakers blocked in its
> handshake_turn_sem semaphore. We can actually avoid this issue
> altogether if after removing the JavaThread from the active list and
> before triggering the terminating safepoint, we wait until the
> JavaThread is no longer protected by a ThreadsList reference.
This solution looks great to me, but of course I am biased here.
Thanks for picking this one up.
> Tested in mach5 tiers 1-6.
More information about the hotspot-runtime-dev