RFR(T) : 8244141 : use @requires and SkippedException in some hotspot/runtime tests

gerard ziemski gerard.ziemski at oracle.com
Wed Apr 29 20:35:20 UTC 2020

hi Igor,

On 4/29/20 2:06 PM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8244141/webrev.00
>> 82 lines changed: 15 ins; 31 del; 36 mod;
> Hi all,
> could you please review this trivial patch for runtime tests?
> from JBS:
>> some hotspot/runtime tests use custom logic to skip execution when run on certain platforms and/or in configurations, more modern way to do it is to use @requires or SkippedException.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244141
> webrev: http://cr.openjdk.java.net/~iignatyev//8244141/webrev.00
> testing: the changed tests
Looks good.

In "CDSCompressedKPtrs.java" what exactly happens when we throw 
SkippedException? I assume we have some mechanism now to detect/report 
skipped tests? I like the idea.

Also, there are more than these 5 tests that check for platforms the 
"old way", so there is not going to be a coordinated effort to change 
them to the new way?


More information about the hotspot-runtime-dev mailing list