RFR 8236625 Remove writeable macro from JVM flags declaration
ioi.lam at oracle.com
Tue Jan 7 16:06:26 UTC 2020
Thanks for the review.
The JVMFlag::is_XXX APIs are implemented with strcmp, so in-lining them
won't give much speed up but will make the code bigger.
I am working on a follow-on patch (JDK-8236606) which, among other
things, changes JVMFlag::_type from char* to an enum. In that patch the
is_XXX APIs will be inlined.
On 1/7/20 7:35 AM, gerard ziemski wrote:
> Very nice cleanup!
> Would it make sense to also inline the "JVMFlag::is_" APIs if we
> decide to inline "JVMFlag::get_" and "JVM::set_" to keep them together
> in the same file for easier readability?
> On 1/2/20 6:23 PM, Ioi Lam wrote:
>> The "writeable" macro was used by commercial JVM flags, which have been
>> removed from the JDK (see JDK-8205505). No flags in the JDK today use
>> macro. It should be removed.
>> I also inlined some accessor functions in the JVMFlag class for slightly
>> more compact code.
>> - Ioi
More information about the hotspot-runtime-dev