RFR 8236625 Remove writeable macro from JVM flags declaration

Ioi Lam ioi.lam at oracle.com
Tue Jan 7 16:06:26 UTC 2020

Hi Gerard,

Thanks for the review.

The JVMFlag::is_XXX APIs are implemented with strcmp, so in-lining them 
won't give much speed up but will make the code bigger.

I am working on a follow-on patch (JDK-8236606) which, among other 
things, changes JVMFlag::_type from char* to an enum. In that patch the 
is_XXX APIs will be inlined.

- Ioi

On 1/7/20 7:35 AM, gerard ziemski wrote:
> Very nice cleanup!
> Would it make sense to also inline the "JVMFlag::is_" APIs if we 
> decide to inline "JVMFlag::get_" and "JVM::set_" to keep them together 
> in the same file for easier readability?
> cheers
> On 1/2/20 6:23 PM, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8236625
>> http://cr.openjdk.java.net/~iklam/jdk15/8236625-remove-writeable-flag-macro.v01/ 
>> The "writeable" macro was used by commercial JVM flags, which have been
>> removed from the JDK (see JDK-8205505). No flags in the JDK today use 
>> this
>> macro. It should be removed.
>> I also inlined some accessor functions in the JVMFlag class for slightly
>> more compact code.
>> Thanks
>> - Ioi

More information about the hotspot-runtime-dev mailing list