RFR(S): 8179317: [TESTBUG] rewrite runtime shell tests in java

mikhailo.seledtsov at oracle.com mikhailo.seledtsov at oracle.com
Mon Jan 27 20:07:20 UTC 2020

Hi Igor,

   Thank you for taking a look at the change.

On 1/24/20 7:14 PM, Igor Ignatyev wrote:
> Hi Misha,
> in general looks good to me, I have two comments though:
> - why did you put 'new OutputAnalyzer(pb.start())' into parentheses?
Some old habit, I guess. I can remove the parentheses.
> - in vmTestbase, TestDescription.java was originally used to be just that a test description w/o any test logic inside, and I'd prefer it stays that way. in other words, I'd recommend you to rename test/hotspot/jtreg/vmTestbase/metaspace/flags/maxMetaspaceSize/TestDescription.java to test/hotspot/jtreg/vmTestbase/metaspace/flags/maxMetaspaceSize/Test.java for example. this will require the corresponding change in test/hotspot/jtreg/TEST.groups

Will do.



> Thanks,
> -- Igor
>> On Jan 24, 2020, at 5:56 PM, mikhailo.seledtsov at oracle.com wrote:
>> Please review this change that converts HotSpot/Runtime shell tests to Java
>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8179317
>>      Webrev: http://cr.openjdk.java.net/~mseledtsov/8179317.00/
>>      Testing:
>>         Ran the affected tests
>> Thank you,
>> Misha

More information about the hotspot-runtime-dev mailing list