RFR(XXS) [TESTBUG] TestOptionsWithRanges_generate.sh should be excluded from testing
igor.ignatyev at oracle.com
Wed Jan 29 18:36:01 UTC 2020
The usual semantic of @ignore is “this *test* should not be run” , so using it here might be confusing. In other words, your patch won’t exclude this file from being counted as a test, and will just mark it as “broken”, and there is existing tooling which tracks such tests. The cleaner way would be to replace @ character with ‘at’ so jtreg won’t see this shell file as a test (even remove @).
> On Jan 29, 2020, at 9:32 AM, Ioi Lam <IOI.LAM at oracle.com> wrote:
> Hi, please review this very small change:
> --- a/test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges_generate.sh
> +++ b/test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges_generate.sh
> @@ -20,6 +20,8 @@
> # questions.
> # Generate the @test tags inside TestOptionsWithRanges.java
> +# @ignore
> +# This is not a test, but rather a script that generates actual tests.
> echo "// --- start auto-generated"
> echo "// the following portion is auto-generated by $0. Do not edit manually."
> - Ioi
More information about the hotspot-runtime-dev