RFR(S): 8248657: Windows: strengthening in ThreadCritical regarding memory model

Andrew Haley aph at redhat.com
Sun Jul 12 14:25:56 UTC 2020

On 11/07/2020 15:15, Kim Barrett wrote:

 > This change seems to me to make the code noticeably simpler and
 > easier to understand, while also making it platform-independent
 > (eliminating a non-TSO race).

Which is, let us not forget, undefined behaviour. It's best to treat
all such cases as bugs, even if they don't affect x86. But it's not
always non-TSO machines that come out badly: this reminds me of
JDK-8225716, a race condition which only showed on x86-32.

 > Those seem like good things, regardless of any aarch64 port that
 > might be coming.


My opinion is that unnecessary platform dependencies are in effect
technical debt. Another example is the use of non-portable integer
types in AArch64 -- to a large extent my doing -- and it makes sense
to do the cleanup in mainline. That way the Windows import patches
will be as clean and simple as they can be.

Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the hotspot-runtime-dev mailing list