RFR: 8248817: Windows: Improving common cross-platform code

Ludovic Henry luhenry at microsoft.com
Fri Jul 17 18:26:21 UTC 2020

Hi Kim,

I've updated the webrev at http://cr.openjdk.java.net/~burban/luhenry/8248817-atomics/webrev.04 with these spacing fixes.

From: Kim Barrett <kim.barrett at oracle.com>
Sent: Thursday, July 16, 2020 18:43
To: Ludovic Henry
Cc: David Holmes; hotspot-runtime-dev at openjdk.java.net; openjdk-aarch64
Subject: Re: RFR: 8248817: Windows: Improving common cross-platform code

> On Jul 16, 2020, at 6:00 PM, Ludovic Henry <luhenry at microsoft.com> wrote:
> I've upload these latest changes to https://nam06.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~burban%2Fluhenry%2F8248817-atomics%2Fwebrev.04&data=02%7C01%7Cluhenry%40microsoft.com%7C2adf5828b4e94998970908d829f32633%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637305471582207295&sdata=VbHwg0QeJT4rzAtupDoktQLag34s7fWSeP59gGaoywg%3D&reserved=0

The change from "StubName" => "IntrinsicName" made the indenting of
arguments in the calls no longer lined up normally. Line 65, line 82,
and lines 104-5 are now abnormally indented.

Other than that, looks good.  I don't need another webrev for a fix of
the indentation.

More information about the hotspot-runtime-dev mailing list