RFR(S): 8247732: validate user-input intrinsic_ids in ControlIntrinsic

Tobias Hartmann tobias.hartmann at oracle.com
Thu Jul 23 09:13:41 UTC 2020

On 22.07.20 09:12, Liu, Xin wrote:
> 1. I move the validation logic for compiler directives to compilerOracle::scan_flag_and_value.  
> If something wrong  happens in parser, the patch will "gracefully" quit JVM using jvm_exit(1). is that okay? 

With "piggy-back on the error mechanism" I meant that you should use the existing bailout mechanism
in the parser. In this case, couldn't you simply put the error message in 'errorbuf' and let the
caller take care of handling it?

Best regards,

More information about the hotspot-runtime-dev mailing list