RFR (T) 8250519: [REDO] Move mirror oops from Universe into OopStorage

David Holmes david.holmes at oracle.com
Fri Jul 24 23:52:33 UTC 2020

Hi Coleen,

On 25/07/2020 7:07 am, coleen.phillimore at oracle.com wrote:
> Summary: The original patch but add a null pointer check so an OopHandle 
> is not created if a NULL is read from the archive.
> If a NULL is read from the archive, we shouldn't create an OopHandle for 
> it because one will be created in initialize_basic_type_mirrors.  The 
> assert added in the previous patch I pushed detected that.

Your fix to skip NULL seems reasonable but I'm left confused as to when 
and why we will find NULL for these basic type mirrors. Is it only the 
reference types that will be NULL?


> incremental change to original change: 
> http://cr.openjdk.java.net/~coleenp/2020/8250519.01.incr/webrev
> full webrev at http://cr.openjdk.java.net/~coleenp/2020/8250519.01/webrev
> Retested with tier1-3.
> Thanks,
> Coleen

More information about the hotspot-runtime-dev mailing list