RFR: 8248817: Windows: Improving common cross-platform code

David Holmes david.holmes at oracle.com
Thu Jul 30 12:20:37 UTC 2020

On 30/07/2020 9:54 pm, Kim Barrett wrote:
>> On Jul 30, 2020, at 2:56 AM, David Holmes <david.holmes at oracle.com> wrote:
>> Changeset: c35fba4bce35
>> Author:    dholmes
>> Date:      2020-07-30 02:47 -0400
>> URL:       https://hg.openjdk.java.net/jdk/jdk/rev/c35fba4bce35
>> 8250810: Push missing parts of JDK-8248817
>> Summary: Push changes from JDK-8248817 that were accidentally excluded from the commit.
>> Reviewed-by: kbarrett, dholmes
>> Contributed-by: Ludovic Henry <luhenry at microsoft.com>
>> ! src/hotspot/os/windows/os_windows.cpp
>> ! src/hotspot/os_cpu/windows_x86/thread_windows_x86.cpp
> For the record, I only reviewed the atomics changes (I always referred to
> that change with my comments and approval; sorry that apparently wasn't
> clear), so I think the other two parts (pushed under JDK-8250810) were only
> reviewed by David. Not a disaster, but potentially an oops.

My fault. With the time lag I overlooked the split with the initial 
commit and I didn't then go back and re-read the email thread to check 
the details.


> Just in general, I think it's better to split unrelated changes like this,
> rather than having an omnibus bug/webrev.  The changes were split into
> multiple webrevs, but all under the same bug, which led to the confusion
> about who had reviewed what.
>> On 30/07/2020 4:40 pm, David Holmes wrote:
>>> Hi Ludovic,
>>> On 30/07/2020 11:45 am, Ludovic Henry wrote:
>>>> Hi David,
>>>> Looking at the change pushed [1], it seems like you pushed only part of the whole change (the bits related to atomics). It's missing the other two webrevs linked in the first email ([2] and [3]). What would be the best way to proceed? Would you like me to submit another review?
>>> Aaarghhh! Sorry. I'll file a new bug and push the other bits under it.
>>> David
>>>> Thanks,
>>>> Ludovic
>>>> [1] https://hg.openjdk.java.net/jdk/jdk/rev/bda65def14de
>>>> [2] http://cr.openjdk.java.net/~burban/luhenry/8248817-exception-handling/
>>>> [3] http://cr.openjdk.java.net/~burban/luhenry/8248817-frames/

More information about the hotspot-runtime-dev mailing list