RFR: 8250636: iso8601_time returns incorrect offset part on MacOS

gerard ziemski gerard.ziemski at oracle.com
Thu Jul 30 16:52:39 UTC 2020

hi Dmitry,

Looks good when it comes to the core approach of the fix, but may I 
suggest simplifying the code a bit? Perhaps something like this:


I do not like the duplication of "const time_t” constants and I don’t 
think that including more logic code in “get_timezone()” does much for 
readability of the code here.

Thank you for catching and fixing it!


On 7/30/20 4:32 AM, Dmitry Cherepanov wrote:
> Hello,
> Please review a small change for fixing offset (timezone) part of the
> string returned by os::iso8601_time on MacOS. The patch negates
> tm_gmtoff and skips the DST adjustment when tm_gmtoff is used. The
> behavior on other platforms should remain unchanged. More details are in
> the bug report.
> JBS: https://bugs.openjdk.java.net/browse/JDK-8250636
> Webrev: http://cr.openjdk.java.net/~dcherepanov/8250636/webrev.v3/
> Thanks,
> Dmitry

More information about the hotspot-runtime-dev mailing list